Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide black bands on video thumbnails #55

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

Oli0li
Copy link
Contributor

@Oli0li Oli0li commented Sep 13, 2023

I just looked into this issue:
#20

It is quite an odd case as on my Mac, I could see the thumbnails display with black bands on my laptop screen but they displayed correctly on my second screen. Adding overflow-hidden on the link seems to fix the issue and does not seem to trigger other issues as far as I can tell on my machine checking it on Safari, Google Chrome and Mozilla Firefox.

I found the idea to use "overflow-hidden" reading some of the answers here: https://stackoverflow.com/questions/13220715/removing-black-borders-43-on-youtube-thumbnails

Before:

Screen.Recording.2023-09-13.at.18.08.29.mov

After:

Screen.Recording.2023-09-13.at.18.07.16.mov

This is in order to fix an issue present on Safari.
adrienpoly#20
@adrienpoly
Copy link
Owner

Thanks it works perfectly 🎉

@adrienpoly adrienpoly merged commit 009bc6a into adrienpoly:main Sep 13, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants