Hide black bands on video thumbnails #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just looked into this issue:
#20
It is quite an odd case as on my Mac, I could see the thumbnails display with black bands on my laptop screen but they displayed correctly on my second screen. Adding overflow-hidden on the link seems to fix the issue and does not seem to trigger other issues as far as I can tell on my machine checking it on Safari, Google Chrome and Mozilla Firefox.
I found the idea to use "overflow-hidden" reading some of the answers here: https://stackoverflow.com/questions/13220715/removing-black-borders-43-on-youtube-thumbnails
Before:
Screen.Recording.2023-09-13.at.18.08.29.mov
After:
Screen.Recording.2023-09-13.at.18.07.16.mov